Implement additional model config params #45
Merged
+225
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JasonTheAdams
approved these changes
Aug 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds model config params for:
outputFileType(inlineorremote)outputMediaOrientation(square,landscape, orportrait)outputMediaAspectRatio(a string like3:2or16:9etc.)The
outputMediaAspectRatiois a more specific version ofoutputMediaOrientation, but both are valid to have. Some use-cases may require a specific aspect ratio, while for others purely the orientation (without a precise aspect ratio) may be sufficient.Aside: Other than common sense for why these are relevant for e.g. image generation, I came across a concrete need while working on #39, specifically in d9b32fc.